perf(eio): remove Fiber.first from read loop - #86
Open
anmonteiro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
Fiber.firstfrom the Eio read hot path and unblock client shutdown by explicitly shutting down the socket receive side.Why
Fiber.firstwas running inside the inner read loop, which adds avoidable fiber scheduling and allocation overhead on every read operation.On a local 1.5 GiB upload benchmark using the existing
curl --http2-prior-knowledgeharness against a small Eio H2 server, this changed the upload time from roughly:6.52s(235.64 MiB/s)3.73s(411.40 MiB/s)Validation
dune build @all