Repository navigation
Editor cleanup and Node.js 24 GitHub actions - #23
Merged
Merged
Conversation
Saving without applying left services.toml out of step with what was running, so the only way to write the configuration is now Apply (or Start All while stopped); the Save button and its Ctrl+S shortcut are gone. Validate becomes a filled teal button, set apart from Apply's accent color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tab reaches it, Enter or Space activates it, and a focus ring shows when it has focus, like the std buttons beside it. Modified keys are left to bubble so window shortcuts such as Ctrl+Return still work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Switching between the service list and the editor removes whichever control had focus, and with nothing focused no shortcut fired until the window was clicked. Hand focus back to the shortcut scope on every view change. The e2e now applies from a focused Validate button, so the Ctrl+E that follows covers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
actions/checkout v4 -> v7, actions/upload-artifact v4 -> v7 and actions/download-artifact v4 -> v8 all run on Node.js 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrewchen5678
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates #22 into this PR.
Editor
services.tomlwithout running it, leaving the file out of step with the running configuration. Apply (Start All while stopped) is now the only way to write it. The Save button, itssavecallback, and its Ctrl+S shortcut are gone; the no-config banner, README (Configuration, Usage, shortcut table, e2e description) andci/unix/e2e.share updated to match.Buttononly offersprimary, so Validate is a smallTintedButton(filled teal, with light and dark variants; hover/pressed/disabled states; button accessibility role, label and default action, so tests and assistive tech still find it by its label).GitHub actions — move off the deprecated Node.js 20 runtime:
actions/checkoutv4 → v7actions/upload-artifactv4 → v7actions/download-artifactv4 → v8The breaking changes in between don't affect these workflows: checkout v7 blocks fork checkouts under
pull_request_target/workflow_run(not used here); upload-artifact v7 only adds an opt-inarchive: false; download-artifact v8 fails on digest mismatches instead of warning and skips unzipping non-zip artifacts (ours are all zipped). The artifact actions only run in the manual release workflow, so the next release exercises them.ci/unix/ci.shpasses on Linux, including the desktop e2e.Also bumps the version to 0.0.19.
🤖 Generated with Claude Code