Skip to content

fix: deduplicate doctyple list in extend_boot_info (backport #83)#84

Merged
barredterra merged 1 commit into
version-15from
mergify/bp/version-15/pr-83
Jun 26, 2026
Merged

fix: deduplicate doctyple list in extend_boot_info (backport #83)#84
barredterra merged 1 commit into
version-15from
mergify/bp/version-15/pr-83

Conversation

@mergify

@mergify mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Addresses #82


This is an automatic backport of pull request #83 done by Mergify.

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge — the change is minimal and directly addresses the duplication issue reported in #82.

The fix is correct and well-tested. The only open question is whether the non-deterministic ordering of list(set(...)) matters for consumers of enabled_doctypes; currently it is used for membership checks on the client side, so ordering is not critical, but switching to sorted() would make the output fully stable.

No files require special attention beyond the minor ordering note on pdf_on_submit/utils.py.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[extend_boot_info called] --> B[Fetch PDF on Submit Settings]
    B --> C{show_pdf_button enabled?}
    C -- No --> D[enabled_doctypes = empty list]
    C -- Yes --> E[Iterate settings.enabled_for rows]
    E --> F[Extract document_type per row]
    F --> G[Build set to deduplicate doctypes]
    G --> H[Convert set to list]
    H --> I[enabled_doctypes = deduplicated list]
    D --> J[Attach pdf_on_submit to bootinfo]
    I --> J
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[extend_boot_info called] --> B[Fetch PDF on Submit Settings]
    B --> C{show_pdf_button enabled?}
    C -- No --> D[enabled_doctypes = empty list]
    C -- Yes --> E[Iterate settings.enabled_for rows]
    E --> F[Extract document_type per row]
    F --> G[Build set to deduplicate doctypes]
    G --> H[Convert set to list]
    H --> I[enabled_doctypes = deduplicated list]
    D --> J[Attach pdf_on_submit to bootinfo]
    I --> J
Loading

Fix All in Cursor

Reviews (1): Last reviewed commit: "fix: deduplicate doctyple list in extend..." | Re-trigger Greptile

Comment thread pdf_on_submit/utils.py
@barredterra
barredterra merged commit 7e3929f into version-15 Jun 26, 2026
8 checks passed
@barredterra
barredterra deleted the mergify/bp/version-15/pr-83 branch June 26, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants