Skip to content

fix: deduplicate doctyple list in extend_boot_info#83

Merged
barredterra merged 3 commits into
version-16from
fix-duplicate-button
Jun 26, 2026
Merged

fix: deduplicate doctyple list in extend_boot_info#83
barredterra merged 3 commits into
version-16from
fix-duplicate-button

Conversation

@HenningWendtland

@HenningWendtland HenningWendtland commented Jun 26, 2026

Copy link
Copy Markdown
Member

Addresses #82

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the change is minimal, correctly targeted at the reported bug, and covered by a new test.

The change is a single-line fix replacing a list comprehension with a set comprehension to eliminate duplicate doctype names from the boot payload. The new test explicitly reproduces the bug scenario (multiple rows for the same doctype) and verifies only one entry appears. No existing behavior is altered for configurations that were already duplicate-free.

No files require special attention.

Reviews (3): Last reviewed commit: "fix: remove unneeded defensive check" | Re-trigger Greptile

Comment thread pdf_on_submit/utils.py Outdated
@barredterra
barredterra merged commit 5aab3ed into version-16 Jun 26, 2026
10 checks passed
@barredterra
barredterra deleted the fix-duplicate-button branch June 26, 2026 11:00
@barredterra

Copy link
Copy Markdown
Member

@Mergifyio backport version-15

@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

backport version-15

✅ Backports have been created

Details

barredterra pushed a commit that referenced this pull request Jun 26, 2026
Co-authored-by: Henning Wendtland <156231187+HenningWendtland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants