Skip to content

Attempt to make SpriteMask on child GameObjects work during PNG render #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
all-iver wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Attempt to make SpriteMask on child GameObjects work during PNG render #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c70d130
Attempt to make SpriteMask on child GameObjects work during PNG render
all-iver Feb 13, 2023
7ba2c35
Fix typo for UI shapes
all-iver Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion Assets/Shapes2D/Editor/ShapeEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,23 @@ private static Vector2 RenderToTexture2D(string path, Shape shape, float pixelsP
RenderTexture oldRT = RenderTexture.active;
RenderTexture.active = rt;

// create a backup of the shape's layer and enabled state so we can manipulate
// them and restore later. set all shapes to layer 31 and disable their
// graphics component. this leaves any other components enabled so e.g.
// SpriteMask on a child will still affect a parent.
List<(int oldLayer, bool wasEnabled)> backup = new List<(int oldLayer, bool wasEnabled)>();
foreach (Shape s in shapes) {
if (canvas) {
backup.Add((s.gameObject.layer, s.GetComponent<Graphic>().enabled));
s.gameObject.layer = 31;
s.GetComponent<Graphic>().enabled = false;
} else {
backup.Add((s.gameObject.layer, s.gameObject.GetComponent<SpriteRenderer>().enabled));
s.gameObject.layer = 31;
s.gameObject.GetComponent<SpriteRenderer>().enabled = false;
}
}

// draw each shape with blending turned off, and layer them on top of each
// other with blending between shapes but not between a shape and the
// camera's background color, which is what would happen if we just let the
Expand All @@ -224,7 +241,16 @@ private static Vector2 RenderToTexture2D(string path, Shape shape, float pixelsP
// shapes but not between a shape and the background color, so that's why
// we have to do it manually.
Texture2D dstTex = null;
foreach (Shape s in shapes) {
for (int i = 0; i < shapes.Count; i++) {
if (!backup[i].wasEnabled)
continue;
// set this shape's graphic's enabled state to true so it will render
var s = shapes[i];
if (canvas) {
s.GetComponent<Graphic>().enabled = true;
} else {
s.gameObject.GetComponent<SpriteRenderer>().enabled = true;
}
if (canvas) {
Graphic g = s.GetComponent<Graphic>();
g.enabled = true;
Expand All @@ -249,6 +275,23 @@ private static Vector2 RenderToTexture2D(string path, Shape shape, float pixelsP
s.GetComponent<Mask>().showMaskGraphic = false;
}
}
// set the graphic's enabled back to false
if (canvas) {
s.GetComponent<Graphic>().enabled = false;
} else {
s.gameObject.GetComponent<SpriteRenderer>().enabled = false;
}
}

// restore the layers and graphic enabled states
for (int i = 0; i < shapes.Count; i++) {
var s = shapes[i];
s.gameObject.layer = backup[i].oldLayer;
if (canvas) {
s.GetComponent<Graphic>().enabled = backup[i].wasEnabled;
} else {
s.gameObject.GetComponent<SpriteRenderer>().enabled = backup[i].wasEnabled;
}
}

// put the old render texture back
Expand Down