Attempt to make SpriteMask on child GameObjects work during PNG render - #22
Open
all-iver wants to merge 2 commits into
Open
Attempt to make SpriteMask on child GameObjects work during PNG render#22all-iver wants to merge 2 commits into
all-iver wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very quick update to try and get SpriteMask to work during convert to sprite, if it's on a child GameObject. During convert to sprite, shapes are rendered one at a time, and prior to this only the shape currently being rendered was on a layer visible to the camera, so anything else in the hierarchy would not affect the render. This change makes it so the entire hierarchy is on the correct layer, but graphics components are disabled except for the shape being rendered. Barely tested and not tested at all with UI.
Before merging this would need some cleanup to factor with DisableUIGraphics(). Also, if a SpriteMask component is on a child but the child doesn't have a Shape component, it won't affect the png.