ci: quality gates phase 1 -- dupl repo-wide, gocognit clean-as-you-code (goal 0109) - #239
Merged
Conversation
…de (goal 0109) dupl@150 enabled with named deliberate-family exclusions (test twins, configuresvc's per-entity seed/CRUD shape, atlasservice_builtin.go) -- lands green from a full measurement run, fails on NEW duplication anywhere else. gocognit@15 gates NEW/CHANGED code only via --enable-only + --new-from-merge-base (lefthook gocognit-new job + CI step; lint job checkout gains fetch-depth 0 for the merge-base) -- 25 legacy production functions sit over threshold, so a repo-wide gate would fail every build or mean nothing. TS-side sonarjs + diff-cover deferred behind the in-flight npm dependency batch. Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alicoding
enabled auto-merge (squash)
August 18, 2026 17:54
…lls on flaky mirrors Three e2e shards hung for their full 15-minute cap in one day, every one inside `npx playwright install --with-deps chromium` while apt fetched from ubuntu mirrors. Browser binaries now cache keyed by the installed @playwright/test version; a hit skips the install entirely (the runner image already carries Chromium's system deps), so only a real Playwright bump pays the download path again. Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ready has the deps The 15-minute shard hangs persisted on cache-miss runs: the stall is --with-deps' apt fetch itself, not the browser download. The ubuntu runner image ships Chromium's system libraries, so the install is browser-binaries-only now (and skipped entirely on a cache hit). Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measurement-first wiring (full read-only run recorded in the goal file before any threshold was committed):
atlasservice_builtin.go. Gate lands green today; new duplication anywhere else fails the build. Anti-gaming: named-family exclusions with recorded reasons, never a threshold raise.--enable-only gocognit --new-from-merge-base=origin/mainas a lefthook job + CI step instead of failing every build or inflating the threshold. Lint job checkout gainsfetch-depth: 0for the merge-base.testing.md carries the standing rules; both gates verified green locally on this branch.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd