ci: sonarjs gates -- cognitive complexity at 15, duplication rules at error (goal 0109 phase 2b) - #246
Merged
Merged
Conversation
… error (goal 0109 phase 2b)
eslint-plugin-sonarjs@4.2.0, thresholds from a full measurement run
over src/: no-duplicated-branches and no-identical-functions land
clean repo-wide and gate at error; cognitive-complexity gates at 15
with the 11 legacy sites over threshold (max 32) grandfathered by
named disable-with-reason comments -- new code gates immediately, the
burn-down list IS the greppable disables ("goal 0109 burn-down").
no-duplicate-string stays OFF per Sonar's own default posture (i18n
keys/testids are the documented noise class). Completes goal 0109's
acceptance; the goal file carries the full record.
Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TS counterpart of #239's Go gates, thresholds from a full measurement run over
src/(recorded in the goal file):sonarjs/no-duplicated-branches+sonarjs/no-identical-functions— measured clean repo-wide, gate at error.sonarjs/cognitive-complexityat 15 — 11 legacy sites over threshold (max 32), each grandfathered by a namedeslint-disablewith reason; new code gates at 15 immediately and the burn-down list is the greppable disables (goal 0109 burn-down). Same clean-as-you-code posture as the gocognit merge-base gate.no-duplicate-stringdeliberately OFF (Sonar's own default; i18n keys/testids are the documented noise class).This completes goal 0109's acceptance — research verdicts, measured thresholds, both languages' smell + duplication + diff-coverage gates wired lefthook+CI, testing.md standing rules.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd