Skip to content

fix: Compact density is visible -- 2px row padding, perceptibility pinned #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alicoding merged 1 commit into from
Aug 18, 2026
Merged

fix: Compact density is visible -- 2px row padding, perceptibility pinned #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend/e2e/display-density.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ test('Compact visibly tightens a workflow row, persists across reload, and Comfo

await setDensity(page, 'Compact')
const compactRow = await firstWorkflowRow(page)
await expect.poll(async () => (await compactRow.boundingBox())?.height ?? 0).toBeLessThan(comfortableHeight)
// Perceptibility floor: a density mode the eye can't catch fails its
// one job -- compact must reclaim at least 6px per row, not merely
// measure smaller.
await expect.poll(async () => (await compactRow.boundingBox())?.height ?? 0).toBeLessThanOrEqual(comfortableHeight - 6)

await page.reload()
const afterReloadRow = await firstWorkflowRow(page)
Expand Down
7 changes: 5 additions & 2 deletions frontend/src/app/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@
separate Wails window/document with no .app-shell element of its own
(docs/adr/0033), and this rule must reach both. 4px is Primer's own
--base-size-4 step, ~67% of ActionList's 6px default row padding --
the dominant lever among the in-scope surfaces' current values. */
the dominant lever among the in-scope surfaces' current values.
2px, not a timid step down: a density mode a user cannot SEE at a
glance fails its one job (the 6px->2px cut reads clearly across any
multi-row list; the 44px mobile floor below still wins). */
:root[data-density="compact"] {
--mill-density-row-pad-y: var(--base-size-4, 4px);
--mill-density-row-pad-y: var(--base-size-2, 2px);
}
/* Touch-target floor (docs/goals/0096's DoR: "floor wins over
density"): at the companion breakpoint, compact's row padding
Expand Down
Loading