fix: Compact density is visible -- 2px row padding, perceptibility pinned - #235
Merged
Conversation
…nned The mechanism worked (root attribute -> CSS var -> Primer's own row-padding token) but the lever was homeopathic: 6px->4px per row is under the eye's threshold, which read as the setting doing nothing. Compact now cuts to 2px (8px of height back per row -- clearly legible across any list; the 44px companion-breakpoint floor still wins). The e2e previously asserted only 'smaller than comfortable', green at any imperceptible delta -- it now pins a >=6px per-row reclaim so an invisible density mode can never ship green again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live dogfood report: the density setting "doesn't seem to do anything." Root cause wasn't wiring — the chain (root attribute → CSS var → Primer's row-padding token) worked end to end — the lever was just imperceptible: 6px→4px per row. Compact now cuts row padding to 2px (~8px height reclaimed per row; ~2 extra rows per viewport on the Workflows list, screenshot-verified), the 44px mobile touch floor unchanged. The e2e gains a perceptibility floor (compact must reclaim ≥6px per row) so an invisible density mode can never pass green again — the same "green but visually wrong" class the testing rules name.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd