feat: faceted search -- typed-token scoping across the three search surfaces (goal 0086) - #212
Merged
Conversation
alicoding
enabled auto-merge (squash)
August 18, 2026 00:03
…el, Atlas jump (goal 0086) Adds a shared `<label>: <text>` grammar (shared/facetQuery.ts) so the command palette, Quick Panel, and Atlas jump dialog all scope a search to one type the same way -- a suggestion-chip row (shared/FacetChipRow.tsx) completes the token on click, with typing the token itself as the primary path. filterJumpCards gains a scope parameter for kind/area scoping in the Atlas jump. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd
alicoding
force-pushed
the
faceted-search
branch
from
August 18, 2026 02:52
5cce7bc to
fc7a252
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current-Spotlight pattern the owner asked for, built on the surveyed convergence (typing IS the acceptance — no Tab-accept, no chip state machine):
<label>: <text>grammar (shared/facetQuery.ts, pure, 18 unit cases): the token scopes results to that type, is parsed out of matching (never double-matched), stays visible in the input as the scope indicator, and is removed by ordinary backspace.Proofs: 537 vitest (18 new grammar cases + jump scoping), 26 e2e across the three specs (scoped search, chip-completes, backspace-unscopes, kind/area scoping).
Goal: docs/goals/0086-faceted-search.md.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd