test: guardrail Review-queue specs on dedicated servers -- kills the cohabitation flake - #215
Merged
Conversation
guardrail.spec.ts ran on the shared per-worker server pool, so its Review-queue assertions (exact pending/resolved rows, filter options, the sidebar badge count) could be contaminated by another spec cohabiting the same worker (mcp-write-cancel.spec.ts parking its own MCP approval), producing CI-only failures that never reproduced locally solo. Converts every test to the dedicated-server-per-test pattern guardrail-authoring.spec.ts already uses (own chromium.launch + spawnMillServer per test, own port pair, mkdtemp dirs, finally- stop+rm). The converted file crossed the 500-line limit, so the Review-queue tests move to a new guardrail-review.spec.ts on its own disjoint port pair. mcpTestClient.ts's connectMCPClient gains an optional explicit port for specs that aren't on the standard per-worker pool. The filterable-by-workflow test's own dedicated server starts with no run history at all, so it now also resolves a second workflow's review item itself (the filter's option list only ever contains workflows with an existing pending/resolved item) instead of relying on another test's residual state, which no longer exists once each test gets its own isolated server. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd
alicoding
enabled auto-merge (squash)
August 18, 2026 01:44
…t the 15m cap with zero failures The recorded revisit trigger (testing.md) fired: pure cap-kills, no red tests. Shard growth is the named lever. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
guardrail.spec's Review-queue tests asserted queue/filter state on the SHARED worker server — contaminable by any cohabitant (mcp-write-cancel parks approvals there) AND order-dependent within its own file (the workflow-filter dropdown only lists workflows with review history, which came free from file order). Same class 0078 fixed for guardrail-authoring; same cure: per-test dedicated servers (split into guardrail.spec + guardrail-review.spec, disjoint port pairs), the filter test now seeds its own history, and connectMCPClient gained an explicit mcpPort param (defaults preserved).
13 relevant e2e green solo + combined + both worker modes. This unblocks #212/#213's shard-2 failures.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FW5GkkAG8du7tNdYLk2zSd