fix: bump MCP round-trip test's shutdown timeout (CI flake) - #21
Merged
Conversation
PR #20's test-go job failed with 'Shutdown: context deadline exceeded' on TestMillMCPService_RealClientRoundTrip -- unrelated to that PR's own diff (composition/graph.go, executionsvc), and a rerun of the exact same failing job went green, confirming a shared-CI-runner timing flake rather than a real bug: 2s was too tight a grace window for a real network server's Shutdown() under variable runner load. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft
alicoding
enabled auto-merge (squash)
August 12, 2026 14:00
alicoding
added a commit
that referenced
this pull request
Aug 12, 2026
…og item (#26) Owner-directed: record a recurring problem the moment it's found, not just individually re-diagnose and shrug it off each time. Three distinct specs have each failed once on a shard then gone green on rerun across three different PRs tonight (resizable-table.spec.ts, canvas-live-sync.spec.ts, and the already-fixed MCP shutdown-timeout flake, PR #21) -- worth investigating as a batch rather than re-establishing the same 'confirmed transient, moving on' verdict every time it recurs. Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
alicoding
added a commit
that referenced
this pull request
Aug 15, 2026
PR #20's test-go job failed with 'Shutdown: context deadline exceeded' on TestMillMCPService_RealClientRoundTrip -- unrelated to that PR's own diff (composition/graph.go, executionsvc), and a rerun of the exact same failing job went green, confirming a shared-CI-runner timing flake rather than a real bug: 2s was too tight a grace window for a real network server's Shutdown() under variable runner load. Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft