Skip to content

Commit 9ba2138

Browse files
alicodingclaude
andauthored
fix: bump MCP round-trip test's shutdown timeout 2s→10s (CI flake) (#21)
PR #20's test-go job failed with 'Shutdown: context deadline exceeded' on TestMillMCPService_RealClientRoundTrip -- unrelated to that PR's own diff (composition/graph.go, executionsvc), and a rerun of the exact same failing job went green, confirming a shared-CI-runner timing flake rather than a real bug: 2s was too tight a grace window for a real network server's Shutdown() under variable runner load. Claude-Session: https://claude.ai/code/session_01FYwojT8GdUbYSoggbvEFft Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent 8eca744 commit 9ba2138

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

frontend/bindings/github.com/alicoding/mill/internal/services/executionsvc/models.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,10 @@ export interface RunStep {
208208
* Input/InputAttributes are this step's recorded INPUT (docs/adr/0031
209209
* item 3): the immediately-preceding EXECUTED step's own recorded
210210
* Payload/Attributes, or the run's own seeded starting values for
211-
* the first executed step. Previously undiscoverable at all -- only
212-
* a step's OUTPUT was ever surfaced. Input deliberately has NO
213-
* omitempty, matching Output below -- goal 0021 gap 3, caught live:
214-
* a run started with no payload seeded a genuinely empty first-step
215-
* Input, and omitempty dropped the JSON key entirely over MCP,
216-
* reading as "the field doesn't exist" rather than "it's empty" --
217-
* indistinguishable from a real mapping bug. An always-present key
218-
* (empty string when there's truly nothing) is unambiguous.
211+
* the first executed step. No omitempty on Input, matching Output
212+
* below (goal 0021 gap 3): omitempty on a genuinely-empty first
213+
* step dropped the JSON key entirely over MCP, indistinguishable
214+
* from a real mapping bug.
219215
*/
220216
"input": string;
221217
"inputAttributes"?: { [_ in string]?: any } | null;

internal/services/mcpsvc/millmcpservice_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ func TestMillMCPService_RealClientRoundTrip(t *testing.T) {
3333
t.Fatalf("Start: %v", err)
3434
}
3535
defer func() {
36-
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
36+
// 2s previously flaked on shared CI runners under load
37+
// ("Shutdown: context deadline exceeded") -- confirmed a runner-
38+
// timing flake, not a real bug, by rerunning the exact failing
39+
// job to green (goal 0021 Phase-1-remainder PR #20, 2026-08-12).
40+
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
3741
defer cancel()
3842
if err := svc.Shutdown(ctx); err != nil {
3943
t.Errorf("Shutdown: %v", err)

0 commit comments

Comments
 (0)