Skip to content

fix(request-logger): redact the x-goog-api-key header #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattpocock wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −1
Open

fix(request-logger): redact the x-goog-api-key header #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions request-logger/render.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,4 +359,18 @@ describe("renderMarkdown header redaction", () => {
expect(out).not.toContain("secret-token");
expect(out).toContain("[REDACTED]");
});

it("hides the x-goog-api-key header", () => {
const out = renderMarkdown({
...BASE,
agent: "Gemini CLI",
renderer: "gemini",
headers: { "x-goog-api-key": "secret-goog-key" },
path: "/v1beta/models/gemini-2.5-pro:generateContent",
requestBody: body(GEMINI_REQUEST),
responseRaw: "",
});
expect(out).not.toContain("secret-goog-key");
expect(out).toContain("[REDACTED]");
});
});
7 changes: 6 additions & 1 deletion request-logger/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@ interface RenderInput {
responseRaw: string;
}

const REDACT = new Set(["authorization", "x-api-key", "api-key"]);
const REDACT = new Set([
"authorization",
"x-api-key",
"api-key",
"x-goog-api-key",
]);

/**
* Turn the raw request bytes into text.
Expand Down