fix(request-logger): redact the x-goog-api-key header - #10
Open
mattpocock wants to merge 1 commit into
Open
Conversation
Gemini sends its key in x-goog-api-key. Without this the key was written in plain text into the log the student reads and can share. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini sends its API key in the
x-goog-api-keyheader. The request-loggerREDACTset held onlyauthorization,x-api-keyandapi-key, so a student running the logger against their own Gemini key got that key written in plain text into the Markdown log — a log the course asks them to read and share.Changes
x-goog-api-keytoREDACTinrequest-logger/render.ts.request-logger/render.test.tsthat proves the value is replaced with[REDACTED].Verification
pnpm vitest run request-logger— 145 tests pass.Note for the maintainer
request-logger/render.tsis onmain, not in the lesson stack. After this merges, move the 25-commit stack onto the newmain:🤖 Generated with Claude Code