Skip to content

Fix: Prevent potential test environment pollution in shared scale clusters #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weizhoublue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent potential test environment pollution in shared scale clusters #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions operator/e2e/tests/scale/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"os"
"strconv"
"testing"
"time"

"github.com/ai-dynamo/grove/operator/e2e/k8s/k8sclient"
"github.com/ai-dynamo/grove/operator/e2e/measurement"
Expand Down Expand Up @@ -64,6 +65,15 @@ func TestMain(m *testing.M) {

code := m.Run()

// Perform a final cascading cleanup before tearing down the cluster to prevent
// resource leakage when the cluster is reused for subsequent tests.
// We use a 5-minute timeout as a safe upper bound; internal operations have their own stricter timeouts.
cleanupCtx, cancel := context.WithTimeout(context.Background(), 5*time.Minute)
defer cancel()
if err := sharedCluster.CleanupWorkloads(cleanupCtx, true); err != nil {
Logger.Errorf("Final cascading cleanup failed: %v", err)
}

sharedCluster.Teardown()

os.Exit(code)
Expand Down
Loading