Fix: Prevent potential test environment pollution in shared scale clusters#626
Open
weizhoublue wants to merge 1 commit into
Open
Fix: Prevent potential test environment pollution in shared scale clusters#626weizhoublue wants to merge 1 commit into
weizhoublue wants to merge 1 commit into
Conversation
…ster pollution Signed-off-by: User <user@example.com>
weizhoublue
requested review from
Ronkahn21,
danbar2,
gflarity,
sanjaychatterjee,
shayasoolin and
unmarshall
as code owners
weizhoublue
changed the title
renormalize
reviewed
Jun 8, 2026
renormalize
left a comment
renormalize
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR @weizhoublue!
Each contribution in grove requires a GitHub issue describing the bug/feature, and the corresponding issue is linked with an implementation PR.
So could you please specify the bug as you've described in this PR's description in a GitHub issue, and then link to that issue in this PR? We have an action that verifies this, and that is currently failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ster pollution
What type of PR is this?
/kind bug
What this PR does / why we need it:
Issue Summary
Running scale tests (e.g., make run-scale-test) against a persistent or reused Kubernetes cluster.
In PR #621, WithSkipCleanupWait() was intentionally introduced in operator/e2e/tests/scale/scale_test.go to measure only the PodCliqueSet deletion latency without waiting for the slow Kubernetes API server and GC to delete all sub-resources (Pods) .
However, an oversight occurred: no thorough final cleanup was enforced at the suite level. Consequently, the test suite exits without ever waiting for the cascading deletion to complete.
A large number of Terminating resources may remain in the cluster for seconds after the scale tests finish.
When the same cluster is reused for subsequent test runs, these leftover resources pollute the environment, leading to scheduling conflicts, test misjudgments, and resource exhaustion.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: