feat(protocol): expose DynKeyExprFormatter for runtime format extension#207
Merged
Conversation
|
The Humble+Jazzy interop test environment has moved to zetta-hiroz-toolkit (private). Shell is kept with a deprecation warning for backwards compatibility; will be removed in a future release.
Add Custom variant to KeyExprFormat backed by an Arc<dyn DynKeyExprFormatter>, an object-safe companion to KeyExprFormatter for external crates that need a different wire format without a hiroz fork. Also add KeyExprFormatterAdapter<T> to bridge any static KeyExprFormatter impl into the dyn path with a single Arc::new() call. Graph::new now derives its liveliness subscription pattern via KeyExprFormat::liveliness_pattern() instead of an internal match, so Custom formats get picked up automatically.
hiroz-bridge and ros2dds backend have moved to zetta-hiroz-toolkit. Remove stale references from docs and cache population script.
YuanYuYuan
force-pushed
the
dev/remove-bridge-devshell
branch
from
2615726 to
56263cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynKeyExprFormatter+KeyExprFormat::Customso external crates can supply a custom wire format without forking hirozros-bridge-interopdevshell and remove all stalehiroz-bridge/ros2ddsreferences from docs, homepage, and cache scriptKey Changes
DynKeyExprFormatter: object-safe&selfcompanion toKeyExprFormatter, suitable forArc<dyn ...>boxingKeyExprFormat::Custom(Arc<dyn DynKeyExprFormatter>): new enum variant; dropsCopy/PartialEq/Eq(Arc not Copy)KeyExprFormatterAdapter<T>: zero-cost bridge from any staticKeyExprFormatterimpl into the dyn pathKeyExprFormat::liveliness_pattern(domain_id): replaces theunreachable!()match inGraph::new, Custom formats are picked up automaticallyros-bridge-interopdevshell: marked deprecated with a warning shellHookhiroz-bridgefrom quick-start table, homepage feature cards, feature-comparison table, and console backend docsBreaking Changes
KeyExprFormatis no longerCopy. Callers that relied on implicit copies must add.clone().