Skip to content

feat: add native CJK karaoke glow support - #49

Merged
Zennmn merged 33 commits into
mainfrom
codex/cjk-karaoke-animation
Aug 22, 2026
Merged

feat: add native CJK karaoke glow support#49
Zennmn merged 33 commits into
mainfrom
codex/cjk-karaoke-animation

Conversation

@Zennmn

@Zennmn Zennmn commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Allow single, unmerged CJK lyric words to use Apple Music's native long-glow branch while preserving Apple's duration/length gates.
  • Restore CJK scale, pivot, and shadow at the host glow animator end seam; leave host-owned translationY untouched.
  • Shorten the CJK return-child delay to the native rise duration for the tested single-word glow envelope.
  • Commit a CJK View baseline only after a0 confirms a newly created special-path Animator, avoiding stale recycled-view tracking when Apple declines the glow gates.
  • Keep classifier rewrites inert until the a0, classifier, z$f, z$g, and timing hooks are all registered successfully.
  • Remove the ineffective nested a0 replay and unused g0 symbol residue; cache z$f listener view lookup to reduce per-frame reflection.

Scope

  • Exact Apple Music 6.5.2/1586 symbols only; merged/multi-character CJK words fail closed.
  • No custom animator and no changes to English lyric behavior.
  • Partial hook installation is fail-closed; it reports degraded without routing CJK into the special branch.

Validation

  • Device smoke-tested on Apple Music 6.5.2/1586: English and CJK animation/glow/recovery remain functional.
  • :app:testDebugUnitTest
  • :app:lintDebug
  • :app:lintVitalRelease
  • :app:assembleRelease
  • git diff --check

Zennmn added 30 commits August 21, 2026 18:28
@Zennmn

Zennmn commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d59021007d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Zennmn

Zennmn commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d551b06c47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Zennmn
Zennmn marked this pull request as ready for review August 22, 2026 11:11
@Zennmn
Zennmn merged commit 4434ed2 into main Aug 22, 2026
2 checks passed
@Zennmn
Zennmn deleted the codex/cjk-karaoke-animation branch August 22, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant