Skip to content

feat: add Lunabeat lyrics source and remove NetEase - #50

Merged
Zennmn merged 6 commits into
mainfrom
codex/lunabeat-pr
Aug 22, 2026
Merged

feat: add Lunabeat lyrics source and remove NetEase#50
Zennmn merged 6 commits into
mainfrom
codex/lunabeat-pr

Conversation

@Zennmn

@Zennmn Zennmn commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Lunabeat TTML Hub import to standalone and embedded lyrics settings.
  • Cache manifest and songs index with ETag/304 and revision refresh; use a dedicated 2 MiB index limit and exact Apple Music ID matching.
  • Skip the known inconsistent manifest.indexSha256, while retaining per-TTML size, structure, and SHA-256 validation.
  • Remove NetEase EAPI/YRC conversion code, UI entries, tests, and documentation; preserve removed-provider entries as manual TTML mappings.
  • Tolerate Lunabeat catalog entries without Apple Music IDs so unrelated records do not invalidate the full index.

Validation

  • :app:testDebugUnitTest
  • :app:lintDebug
  • :app:lintVitalRelease
  • :app:assembleRelease
  • git diff main...HEAD --check

This branch is based directly on main and intentionally does not include the CJK changes from PR #49.

@Zennmn

Zennmn commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: beee09c10a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

KEY_CUSTOM_LYRICS_ENABLED,
default = values.boolean(KEY_LEGACY_ONLINE_LYRIC_REPLACEMENT, default = false),
),
automaticLyricsEnabled = values.boolean(KEY_AUTOMATIC_LYRICS_ENABLED, default = true),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Default automatic lookups to off for existing installs

When upgrading an installation that already has custom_lyrics_enabled=true, the new key is absent and this default silently enables playback-time requests to AMLL, Lunabeat, and AM-Lyrics. Those users previously opted into an offline/manual replacement feature, so merely upgrading now sends each eligible song ID to external services without enabling the new “自动实时补全” switch; default the missing key to false or add an explicit migration/consent step.

Useful? React with 👍 / 👎.

@Zennmn
Zennmn merged commit b2636a9 into main Aug 22, 2026
2 checks passed
@Zennmn
Zennmn deleted the codex/lunabeat-pr branch August 22, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant