feat: add Lunabeat lyrics source and remove NetEase - #50
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: beee09c10a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| KEY_CUSTOM_LYRICS_ENABLED, | ||
| default = values.boolean(KEY_LEGACY_ONLINE_LYRIC_REPLACEMENT, default = false), | ||
| ), | ||
| automaticLyricsEnabled = values.boolean(KEY_AUTOMATIC_LYRICS_ENABLED, default = true), |
There was a problem hiding this comment.
Default automatic lookups to off for existing installs
When upgrading an installation that already has custom_lyrics_enabled=true, the new key is absent and this default silently enables playback-time requests to AMLL, Lunabeat, and AM-Lyrics. Those users previously opted into an offline/manual replacement feature, so merely upgrading now sends each eligible song ID to external services without enabling the new “自动实时补全” switch; default the missing key to false or add an explicit migration/consent step.
Useful? React with 👍 / 👎.
Summary
Validation
This branch is based directly on main and intentionally does not include the CJK changes from PR #49.