Skip to content

ABI breaking style for cxxmodule - #88

Merged
YaaZ merged 4 commits into
YaaZ:masterfrom
GrinlexGH:abi-breaking-style
Jul 27, 2026
Merged

ABI breaking style for cxxmodule#88
YaaZ merged 4 commits into
YaaZ:masterfrom
GrinlexGH:abi-breaking-style

Conversation

@GrinlexGH

Copy link
Copy Markdown

closes #79

@sharadhr sharadhr mentioned this pull request Jul 20, 2026
@YaaZ

YaaZ commented Jul 27, 2026

Copy link
Copy Markdown
Owner

The build fails with older Vulkan-Hpp due to missing VULKAN_HPP_EXPORT and I'm not a fan of breaking compatibility until absolutely necessary.
Can we also add something like #ifndef VULKAN_HPP_EXPORT #define VULKAN_HPP_EXPORT?

@YaaZ

YaaZ commented Jul 27, 2026

Copy link
Copy Markdown
Owner

And there are also issues with operators not being visible:
https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/actions/runs/28442410317/job/90004584085?pr=88

Comment thread include/vk_mem_alloc.hpp Outdated
Co-authored-by: Nikita Gubarkov <764610@gmail.com>
Comment thread include/vk_mem_alloc.hpp Outdated
Co-authored-by: Nikita Gubarkov <764610@gmail.com>

@YaaZ YaaZ left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for that improvement!

@YaaZ
YaaZ merged commit d865b2c into YaaZ:master Jul 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider ABI-breaking style for VMA-Hpp?

2 participants