Issue fixing - #87
Conversation
|
Im not sure about private section of the module |
|
A small nitpick: would it be useful to split this PR up into individual PRs that each addresses one of the issues quoted? It might be easier for review as well. |
|
I see the point of moving only the addition of abi breaking style to a separate pr, because everything else is a minor change, literally three small fixes |
|
Any chance of having this and #88 verified and merged? |
|
Sorry guys, I was really busy in the last couple months, gonna take a look at this soon. I guess there's no better way to make Volk work with modules other than that conditional include? Also, don't we need to support a scenario when Volk is built as a separate module? |
|
There is a CI failure: https://github.com/YaaZ/VulkanMemoryAllocator-Hpp/actions/runs/28969139805/job/89922446044?pr=87 |
Modules are isolated, so the only correct solution is to As I know, volk is C-only library, so I don't think they will make C++ module Strangely, I was sure that I had started the generators |
volk.hinclude whenVMA_HPP_ENABLE_VOLKdefined | Volk integration for c++20 module #85