Repository navigation
Rule Fired on a dictionary node opens its .dict entry (-DICTSOURCE, nlp-engine#475) - #1239
Merged
Merged
Conversation
…isualText#475) On DEV runs with engine 4.2.33 or later the extension passes -DICTSOURCE, so nodes built from .dict entries carry dictfile and dictline. Rule Fired on such a node opens that file at that line; without them it falls back to searching the dictionaries as before. New setting analyzer.dictSource (on by default) turns the switch off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension half of VisualText/nlp-engine#475. Engine 4.2.33 added
-DICTSOURCE(nlp-engine#789), which makes nodes built from.dictentries carry("dictfile" "words.dict") ("dictline" 14).src/nlp.ts: DEV-mode runs pass-DICTSOURCEwhen the installed engine is 4.2.33 or later and the new settinganalyzer.dictSourceis on (the default). Engines from 4.2.15 on exit on an unknown switch, so older engines never get it. Normal and SILENT runs don't get it either: the attributes only matter when you're reading trees.src/treeFile.ts: "Rule Fired" on a dictionary node (pass 0, rule line 0) now openskb/user/<dictfile>beside the tree, with the entry's line selected. A tree without the attributes (an older engine, or the setting off) falls back to the existingsearchInDictionariessearch.package.json: new boolean settinganalyzer.dictSource, on by default.Checks:
tsc --noEmit: no new errors. The one existing error,serverCore.ts(680,83), is also on upstream/master.eslinton the two changed files: clean.final.treelines.I haven't tested it in a live VSCode window. That's worth one click on a dictionary node in a DEV-mode tree before release.
No version bump or CHANGELOG entry; that goes in the next release PR.
🤖 Generated with Claude Code