Repository navigation
Setting: start new rules passes with a @CODE region (nlp-engine#391) - #1237
Merged
ddehilster merged 1 commit intoOct 14, 2026
Merged
Conversation
New setting nlp.newPass.codeRegion (default off). When on, a new rules pass starts with a @code region, which runs before the rules: a place to set up globals for the pass or to skip it with exitpass(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements VisualText/nlp-engine#391 as an opt-in setting.
New setting:
nlp.newPass.codeRegion(default off, so nothing changes for anyone who doesn't turn it on). When it's on, a new rules pass starts with a@CODEregion:As Amnon describes in the issue, a
@CODEregion runs before the rules. It's where to set up globals for the pass, or to skip it withexitpass(), which effectively lets one analyzer run several analyzers' worth of passes.L("hello") = 0;is the placeholder parse-en-us already uses for an empty code region.Testing
tsc --noEmitshows no new errors. The one error it reports, insrc/server/serverCore.ts, is there without this change too.🤖 Generated with Claude Code