Repository navigation
attr="value" on a rule element tests the attribute (#438) (4.2.29) - #785
Merged
Merged
Conversation
A key on a rule element that is not a modifier and has one value is now
an attribute test: _xALPHA [pos="noun"] is vareq=("pos" "noun"). A value
of digits only compares as a number. A key one edit from a modifier
(mtch=) warns "Did you mean match?"; a bare unknown key is still an error.
Also fixes element-form vareq=/varne=/vargt=/varlt= (4.2.26): their value
reached the action as text, so vargt=("count" 2) never matched. Digit
values now become numbers, as from a @pre region.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #782 (#438), the "=" form chosen in review.
_xALPHA [pos="noun"]isvareq=("pos" "noun"). A value of digits only compares as a number (count=3).mtch=(two)) warns in make_ana.log: Element key=mtch is not a modifier; testing it as an attribute. Did you mean match? A bare unknown key ([foo]) is still an error.vareq=/varne=/vargt=/varlt=passed their value as text, sovargt=("count" 2)never matched. Digit values now become numbers, as they do from a @pre region.Tests:
tests/element-eq. Each case is written both ways,attr=valueandvareq=, and the two give the same output. It also covers a number value, sitting besidematch=/one,vargt=, and the typo warning. CI steps are on Windows and Linux.$GITHUB_WORKSPACE), Full English Test the same, and 20 analyzers × 21 inputs with 0 differences vs 4.2.18.-COMPILEANA/-COMPILED) gives the same output as the interpreter.Docs: VisualText/visualtext-files PR to follow.
Batched: don't tag yet.
🤖 Generated with Claude Code