Cast default values to int to prevent null‐default TypeError in closure - #25
Open
ikramagix wants to merge 1 commit into
Open
Cast default values to int to prevent null‐default TypeError in closure#25ikramagix wants to merge 1 commit into
ikramagix wants to merge 1 commit into
Conversation
…or) - lib.php Ensure that each `$defaults->…` lookup in `course_format_options()` is explicitly cast to `int` (falling back to `FORMAT_CARDS_USEDEFAULT`), so the anonymous callback never receives `null` as its third parameter and prevents the TypeError during upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a workaround for Issue #22, preventing the fatal
Argument #3 must be of type int, null givenerror on Moodle 4.5.1 when upgrading format_cards v1.5.0.What it does:
course/format/cards/lib.php, every default value passed into thecreateselectclosure is explicitly cast toint(i.e.(int) $defaults->…) withFORMAT_CARDS_USEDEFAULTas the fallback.Why it’s only a workaround:
How this PR can help you:
lib.phpwith this patched version.Site Admin → Development → Purge all cachesorphp admin/cli/purge_caches.php).Purpose of this PR:
Provide the updated
lib.phpcontent as a base for anyone to restore their Moodle platform and as a starting point for fully fixing Issue #22.