Exception Error v1.5.0 (2025041400) - Upgrade stuck

[behoof]

After upgrading v1.5.0 (2025041400), installation stucked with:

Exception - format_cards::{closure}(): Argument #3 ($default) must be of type int, null given, called in [dirroot]/course/format/cards/lib.php on line 214

Bert

[Vidalia]

Hi Bert, what version were you upgrading from, and what version of Moodle are you running at the moment?

I've just tried the upgrade from v1.4.3 to v1.5.0 on Moodle 4.5 and I didn't see this error.

[behoof]

Hi John, Quick Response! I upgraded from the previous version on Moodle 4.5. I disabled the given line in the code. Now is it working, though I didn’t test subsections. Bert Verzonden vanuit Outlook voor iOS<https://aka.ms/o0ukef>

…

________________________________ Van: John ***@***.***> Verzonden: Monday, April 21, 2025 3:41:18 PM Aan: Vidalia/moodle-format_cards ***@***.***> CC: behoof ***@***.***>; Author ***@***.***> Onderwerp: Re: [Vidalia/moodle-format_cards] Exception Error v1.5.0 (2025041400) - Upgrade stuck (Issue #22) Hi Bert, what version were you upgrading from, and what version of Moodle are you running at the moment? I've just tried the upgrade from v1.4.3 to v1.5.0 on Moodle 4.5 and I didn't see this error. — Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABD5WY6JCVXBPKMYP7CCM2T22TYP5AVCNFSM6AAAAAB3RGB5Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJYGQZTEOJXGA>. You are receiving this because you authored the thread.Message ID: ***@***.***> [https://avatars.githubusercontent.com/u/5794157?s=20&v=4]Vidalia left a comment (Vidalia/moodle-format_cards#22)<#22 (comment)> Hi Bert, what version were you upgrading from, and what version of Moodle are you running at the moment? I've just tried the upgrade from v1.4.3 to v1.5.0 on Moodle 4.5 and I didn't see this error. — Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABD5WY6JCVXBPKMYP7CCM2T22TYP5AVCNFSM6AAAAAB3RGB5Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJYGQZTEOJXGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Vidalia]

Which version of 4.5 specifically? My dev environment defaulted to the latest weekly version 4.5.3+

Line 214 adds the "Subsections" drop-down option to the course settings page, disabling it means you won't be able to choose whether subsections are displayed as cards or as collapsible topics.

The default value for that drop-down should be pulled from the site configuration. If you go to Site Administration -> Plugins -> Course Formats -> Cards format settings, and make sure the "Subsections" option has a value. Save the config, and you should be able to uncomment that line and have it work.

[behoof]

Hi John, I'm using 4.5.3+ (Build: 20250404) Durng upgrade of the course format I got that error. The site Subsection configuration was already active. Commenting line 214 deblocked the upgrade error. I now uncommented line 214 and all is working fine. Thanks for the quick response! Bert van der Hooft

…

________________________________ Van: John ***@***.***> Verzonden: maandag, april 21, 2025 9:23 PM Aan: Vidalia/moodle-format_cards ***@***.***> CC: behoof ***@***.***>; Author ***@***.***> Onderwerp: Re: [Vidalia/moodle-format_cards] Exception Error v1.5.0 (2025041400) - Upgrade stuck (Issue #22) [https://avatars.githubusercontent.com/u/5794157?s=20&v=4]Vidalia left a comment (Vidalia/moodle-format_cards#22)<#22 (comment)> Which version of 4.5 specifically? My dev environment defaulted to the latest weekly version 4.5.3+ Line 214 adds the "Subsections" drop-down option to the course settings page, disabling it means you won't be able to choose whether subsections are displayed as cards or as collapsible topics. The default value for that drop-down should be pulled from the site configuration. If you go to Site Administration -> Plugins -> Course Formats -> Cards format settings, and make sure the "Subsections" option has a value. Save the config, and you should be able to uncomment that line and have it work. — Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABD5WY6D52HWIWZUBDE2QUL22VATXAVCNFSM6AAAAAB3RGB5Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGMYTSMBXG4>. You are receiving this because you authored the thread.

[Vidalia]

Glad it's fixed. Still seems like an odd issue to happen during an upgrade though, I'll leave this issue open for a bit and see if I can recreate the problem or if anyone else runs into the same thing.

[ikramagix]

Hi everyone,

I ran into the exact same crash while working on my own plugin (yeswecanquiz) on Moodle 4.5.1.

While checking lib.php from the moodle-format_cards code, I realized the closure was being called with a null default. I’ve shared a lib.php file in PR #25 that casts all default values to int (falling back to FORMAT_CARDS_USEDEFAULT) so the callback can’t receive null anymore.

With this, we at least prevent the update from crashing and Moodle from throwing a blocking error which takes down the platform. This workaround stops the fatal “Argument #3 must be of type int, null given” error and lets the upgrade/install complete.

I’ll try to dig deeper into a permanent solution when I have time, but for now you can grab the patched lib.php from PR #25 to get unstuck.

I hope this helps! 🙂

— @ikramagix

⚠️ Disclaimer: This is only a temporary unblock to get past the crash. It does not restore the card layout for subsections. Please check PR #25 for detailed instructions.

[Vidalia]

Hi @ikramagix ,

Thank you for looking into this. The changes in your PR mirror the patch that I'd set up, but as far as I can tell the value passed to the closure should never be null. It uses the format_cards/subsectionsascards config value which should be set when the plugin is installed/updated.

If the config value is null, then that means that either something else went wrong during the installation/upgrade process, or I misunderstood the process. You're right that we could just stick a default value in lib.php, but I'd like to know why this config value is unset before we start patching over the problem.

John