Skip to content

[ADD] OD-1192: Add pdf return labels creation logic to return pickings.#5

Closed
benrazanskas wants to merge 5 commits into
12.0from
OD-1192-enable-paazl-return-labels
Closed

[ADD] OD-1192: Add pdf return labels creation logic to return pickings.#5
benrazanskas wants to merge 5 commits into
12.0from
OD-1192-enable-paazl-return-labels

Conversation

@benrazanskas

@benrazanskas benrazanskas commented Jun 3, 2022

Copy link
Copy Markdown

No description provided.

@benrazanskas

benrazanskas commented Jun 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

So the thing is, i'm looking for solution to deal with vanmoof_shipping dependencies while was running OCA tests, since vanmoof_shipping has dependencies and raises lot of checks, maybe you guys have an idea how to overcome on this part. Short story: vanmoof_shipping is asking for box to be added before it lets to do smth about labels, so I had to include this here https://github.com/VanMoof/delivery-carrier/pull/5/files#diff-353f63d411d851c3fea1b07cf49d6ece34db580952e5659d16370bd41a32e687R122-R125
Maybe it's good thing to move unittests in our side modules?

StefanRijnhart
StefanRijnhart reviewed Jun 3, 2022
View reviewed changes
Comment thread delivery_carrier_label_paazl/models/stock_picking.py
StefanRijnhart
StefanRijnhart reviewed Jun 3, 2022
View reviewed changes
Comment thread delivery_carrier_label_paazl/models/stock_picking.py
@MPishpecki

MPishpecki commented Jun 20, 2022

Copy link
Copy Markdown

@benrazanskas we cannot deploy this with a tag. Can you please add it to the buildout the old way and inform us. Either @antonioburic or I deploy it manually or it goes with the next ticket that will be triggered for deployment.

@dkubiak789

dkubiak789 commented Jun 20, 2022 •
edited
Loading

Copy link
Copy Markdown

I added a PRs #505 to OCA/delivery-carrier and #1192 to buildout in odoo-addons.

@MPishpecki

MPishpecki commented Jun 22, 2022

Copy link
Copy Markdown

@dkubiak789 @benrazanskas is still fixing failing tests. Maybe too early for the OCA PR? If you are keeping it please make sure you update the OCA PR for the changes.

@benrazanskas benrazanskas mentioned this pull request Jun 22, 2022
Closed
@benrazanskas benrazanskas force-pushed the OD-1192-enable-paazl-return-labels branch from 6899a16 to 013ee7d Compare June 22, 2022 20:25
@benrazanskas benrazanskas force-pushed the OD-1192-enable-paazl-return-labels branch from 0a3140a to 64d809c Compare June 23, 2022 00:32
@antonioburic

antonioburic commented Jul 18, 2022

Copy link
Copy Markdown

The last commit addresses the feedback from testing - inverted sender/receiver address for return labels.

@antonioburic antonioburic force-pushed the OD-1192-enable-paazl-return-labels branch from c5ed936 to eed7016 Compare July 19, 2022 06:21
@antonioburic antonioburic force-pushed the OD-1192-enable-paazl-return-labels branch from eed7016 to 494cd72 Compare July 20, 2022 05:36
@pankk

pankk commented Mar 9, 2023

Copy link
Copy Markdown

Stale upstream, but were are using the code. Due to a conflict this PR was merged into: #8

@pankk pankk closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes
@antonioburic antonioburic antonioburic approved these changes
@MPishpecki MPishpecki MPishpecki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benrazanskas @MPishpecki @dkubiak789 @antonioburic @pankk @StefanRijnhart