[ADD] OD-1996 zpl format labels in using paazl as carrier.#4
[ADD] OD-1996 zpl format labels in using paazl as carrier.#4benrazanskas wants to merge 8 commits into
Conversation
…paazl module, reworked label method to search format from options that has this type set up.
|
Anyone knows why label format is being pop up in vanmoof_shipping? In that case, we will get pdf format at all times, since it's default even without providing such keyword. So the only step that is still blocking us from getting true .zpl format is this part. |
Good find! Maybe @astirpe knows? (https://github.com/VanMoof/odoo-addons/commit/4fd8d6e62dc82833557c9ba84a8cdc20e2838af8) |
… reuse delivery_carrier methods.
|
I can't remember anymore the reason of https://github.com/VanMoof/odoo-addons/commit/4fd8d6e62dc82833557c9ba84a8cdc20e2838af8 but now |
Thanks for information will remove pop line with vanmoof commit then, after this part gets approved to our branch. |
|
Thanks for the updates so far! Given that we'd like this to go into the OCA, can you document this new option under https://github.com/OCA/delivery-carrier/blob/12.0/delivery_carrier_label_paazl/readme/CONFIGURE.rst? |
|
@benrazanskas what is the status of this PR. I see Stefan was last to comment but I see no changes after. |
@MPishpecki I have last update regards Stefan comment locally, wanted to ask, do I need to rebase and push this branch as new one, like we did before using Holger rebase script? Cuz this PR wasn't closed as my previous ones. |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! We now need a branch against VanMoof/odoo-addons that adds this branch as a merge branch under https://github.com/VanMoof/odoo-addons/blob/12.0/buildout.cfg#L163
79f4b3e to
2008a5f
Compare
Will you create such a branch, so we can see what the tests do? |
Sorry for lately response, on Friday there was public holiday in Lithuania :) Created in here OD-1996, |
|
Nice work @benrazanskas, are you able to raise an OCA PR or shall we do it? |
|
Stale upstream, but were are using the code. Due to a conflict this PR was merged into: #8 |
No description provided.