Skip to content

[ADD] OD-1996 zpl format labels in using paazl as carrier.#4

Closed
benrazanskas wants to merge 8 commits into
12.0from
OD-1996-enable-dhl-shipping-label-print
Closed

[ADD] OD-1996 zpl format labels in using paazl as carrier.#4
benrazanskas wants to merge 8 commits into
12.0from
OD-1996-enable-dhl-shipping-label-print

Conversation

@benrazanskas

Copy link
Copy Markdown

No description provided.

Comment thread base_delivery_carrier_label/models/delivery_carrier_option.py Outdated
Comment thread delivery_carrier_label_paazl/models/stock_picking.py Outdated
…paazl module, reworked label method to search format from options that has this type set up.
@benrazanskas

benrazanskas commented Jun 1, 2022

Copy link
Copy Markdown
Author

Anyone knows why label format is being pop up in vanmoof_shipping? In that case, we will get pdf format at all times, since it's default even without providing such keyword. So the only step that is still blocking us from getting true .zpl format is this part.
https://github.com/VanMoof/odoo-addons/blob/12.0/vanmoof_shipping/models/stock_picking.py#L460
But thats in vamoof part ofc, not with OCA updates.

Comment thread delivery_carrier_label_paazl/tests/test_delivery_carrier_label_paazl.py Outdated
Comment thread delivery_carrier_label_paazl/models/delivery_carrier_option.py Outdated
Comment thread delivery_carrier_label_paazl/tests/test_delivery_carrier_label_paazl.py Outdated
@StefanRijnhart

Copy link
Copy Markdown

Anyone knows why label format is being pop up in vanmoof_shipping? In that case, we will get pdf format at all times, since it's default even without providing such keyword. So the only step that is still blocking us from getting true .zpl format is this part. https://github.com/VanMoof/odoo-addons/blob/12.0/vanmoof_shipping/models/stock_picking.py#L460 But thats in vamoof part ofc, not with OCA updates.

Good find! Maybe @astirpe knows? (https://github.com/VanMoof/odoo-addons/commit/4fd8d6e62dc82833557c9ba84a8cdc20e2838af8)

@astirpe

astirpe commented Jun 7, 2022

Copy link
Copy Markdown

I can't remember anymore the reason of https://github.com/VanMoof/odoo-addons/commit/4fd8d6e62dc82833557c9ba84a8cdc20e2838af8 but now labelFormat is needed so the pop line should be removed

@benrazanskas

Copy link
Copy Markdown
Author

I can't remember anymore the reason of VanMoof/odoo-addons@4fd8d6e but now labelFormat is needed so the pop line should be removed

Thanks for information will remove pop line with vanmoof commit then, after this part gets approved to our branch.

@StefanRijnhart

Copy link
Copy Markdown

Thanks for the updates so far! Given that we'd like this to go into the OCA, can you document this new option under https://github.com/OCA/delivery-carrier/blob/12.0/delivery_carrier_label_paazl/readme/CONFIGURE.rst?

@MPishpecki

Copy link
Copy Markdown

@benrazanskas what is the status of this PR. I see Stefan was last to comment but I see no changes after.

@benrazanskas

Copy link
Copy Markdown
Author

@benrazanskas what is the status of this PR. I see Stefan was last to comment but I see no changes after.

@MPishpecki I have last update regards Stefan comment locally, wanted to ask, do I need to rebase and push this branch as new one, like we did before using Holger rebase script? Cuz this PR wasn't closed as my previous ones.

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We now need a branch against VanMoof/odoo-addons that adds this branch as a merge branch under https://github.com/VanMoof/odoo-addons/blob/12.0/buildout.cfg#L163

@benrazanskas benrazanskas force-pushed the OD-1996-enable-dhl-shipping-label-print branch from 79f4b3e to 2008a5f Compare June 23, 2022 22:41
@StefanRijnhart

Copy link
Copy Markdown

Thanks! We now need a branch against VanMoof/odoo-addons that adds this branch as a merge branch under https://github.com/VanMoof/odoo-addons/blob/12.0/buildout.cfg#L163

Will you create such a branch, so we can see what the tests do?

@benrazanskas

Copy link
Copy Markdown
Author

Thanks! We now need a branch against VanMoof/odoo-addons that adds this branch as a merge branch under https://github.com/VanMoof/odoo-addons/blob/12.0/buildout.cfg#L163

Will you create such a branch, so we can see what the tests do?

Sorry for lately response, on Friday there was public holiday in Lithuania :) Created in here OD-1996,

@antonioburic

Copy link
Copy Markdown

Nice work @benrazanskas, are you able to raise an OCA PR or shall we do it?

@pankk

pankk commented Mar 9, 2023

Copy link
Copy Markdown

Stale upstream, but were are using the code. Due to a conflict this PR was merged into: #8

@pankk pankk closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants