Faster LCD updates on bypass / footswitch changes#170
Merged
sastraxi merged 2 commits intoJun 11, 2026
Conversation
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
Hmmm, I'm seeing the almost the opposite with this one. The footswitch LED and halo update quickly, but the lag for the associated plugin block seems way worse - sometimes almost a second or so. I also sometimes see an LED flash like it's getting updated twice.
rreichenbach
approved these changes
Jun 10, 2026
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good and seems to work well now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every plugin-bypass echo and every footswitch press triggered multiple full-panel SPI blits. Now, we only update the plugin (and footswitch) whose state changed via the incoming message.
Included in this is a small fix for footswitch rendering: these were sized to plugin_height, shorter than their drawn halo+label. The old full-panel blit masked the overflow; partial redraws exposed it. Corrected to the intended footswitch_height.
Snapshots unchanged (pixel-identical), confirming the partial path matches the old full-panel output.