Add configurable LCD SPI speed via system menu#171
Merged
sastraxi merged 1 commit intoJun 10, 2026
Conversation
User-selectable SPI clock (24/48/56/80 MHz) persisted in settings. poll_divisor auto-adjusts so LCD polling tracks actual refresh time. Defaults to 24 MHz (ILI9341 spec); 56 MHz tested stable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rreichenbach
approved these changes
Jun 10, 2026
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
Seems fine. I'm seeing footswitch refresh glitches similar as on #170 but this is probably unrelated to this changeset. I see the same thing regardless of the frequency set.
Would be nice if we had a MessageDialog class that allowed hiding the OK button. Not a big deal though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ILI9341 controller runs reliably above spec — 56 MHz has been tested stable, cutting full-panel refresh from 80ms to 30ms. This PR makes the SPI clock user-selectable (24/48/56/80 MHz) via System Menu → LCD Speed; the choice is persisted in settings and applied at startup.
The polling divisor in the main loop auto-adjusts so LCD polling tracks somewhat-closely with actual refresh time. Additionally, the ADC SPI speed is set based on the LCD speed; experimental settings set it to the spec (1 MHz) while the base setting maintains the existing 240 kHz value (tested on actual hardware).