Skip to content

Stabilize amsg-instant SSE/Web Push parity e2e assertion in release workflow #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tosd0 merged 3 commits into from
Jul 17, 2026
Merged

Stabilize amsg-instant SSE/Web Push parity e2e assertion in release workflow #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72ed584
Initial plan
Copilot Jul 17, 2026
e16d8a6
test: stabilize instant e2e push backup ordering assertion
Copilot Jul 17, 2026
62fadd1
test: document why instant e2e sorts push backups by messageIndex
Tosd0 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/rei-standard-amsg/instant/test/e2e.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,12 @@ describe('e2e: push payload contract parity with amsg-server', () => {
for (const call of router.pushCalls) {
backups.push(JSON.parse(await decryptCapturedPushBody(call.body, subKit)));
}
// Backup pushes are fired concurrently (`backupWork` in index.js) —
// each races through its own async encryption before calling fetch,
// so interception order is NOT the SSE order. Normalize by
// messageIndex: the contract under test is that a given index
// carries the same messageId on both transports.
backups.sort((a, b) => a.messageIndex - b.messageIndex);
assert.equal(backups[0].messageId, payloads[0].messageId);
assert.equal(backups[1].messageId, payloads[1].messageId);
});
Expand Down
Loading