Stabilize amsg-instant SSE/Web Push parity e2e assertion in release workflow#25
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job release
Stabilize amsg-instant SSE/Web Push parity e2e assertion in release workflow
Jul 17, 2026
The bare sort reads as redundant without the reason behind it. Record that SSE backup pushes go out concurrently, so the order they hit the intercepting fetch is unrelated to the SSE order. Claude-Session: https://claude.ai/code/session_011YT96KgPecPVLQnwk2x4Fz
Tosd0
marked this pull request as ready for review
July 17, 2026 09:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
releaseGitHub Actions job was failing due to a flaky e2e assertion in@rei-standard/amsg-instant, not a production runtime defect. The test assumed intercepted Web Push backup calls would always arrive in SSE payload order, which is not guaranteed under async execution.Problem focus
packages/rei-standard-amsg/instant/test/e2e.test.mjshad an order-sensitive assertion in the SSE parity test (payloadsvs decryptedbackups).Change made
messageIndexso the assertion compares semantic sequence rather than fetch timing.Why this is the right scope
messageIdparity between SSE and Web Push) while removing nondeterministic ordering assumptions.