fix(release): unblock the AppImage and Flatpak jobs on the 0.1.0 run - #36
Merged
Merged
Conversation
Two first-run failures, both environmental. The AppImage job builds on ubuntu-22.04, whose gcc bakes _FORTIFY_SOURCE=2 into its specs; the hardening block redefines it to 3, and -Werror turns that redefinition fatal. Undefine before defining. The Flatpak job dies at eu-strip: flatpak-builder shells out to it and the runner image does not carry elfutils.
emir-hasanbegovic
enabled auto-merge (squash)
August 23, 2026 14:02
emir-hasanbegovic
added a commit
that referenced
this pull request
Aug 23, 2026
…odules (#37) Attempt 2 of the 0.1.0 release got both failing jobs past their environment problems and into the next layer. **AppImage:** jammy ships SDL 2.0.20; `SDLGamepadBridge.cpp` uses `SDL_GameControllerPath` / `SDL_JoystickPath`, which need 2.24. The job now builds the pinned SDL 2.30.9 (same version, checksum and gamepad-only feature set as the Flatpak manifest's sdl2 module) and linuxdeploy bundles it. The step runs after setup-qt because that action overwrites `CMAKE_PREFIX_PATH`; the SDL prefix prepends to it. **Flatpak:** SDL2's CMakeLists refuses an in-tree configure, and in-tree is flatpak-builder's default for cmake modules. Both cmake modules (`sdl2`, `dish`) now set `builddir: true`, in the flathub variant too. Same follow-up as #36: retag 0.1.0 on the merge commit and the release reruns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.1.0 tag ran the release pipeline end to end for the first time. The .deb and .rpm containers passed everything, lintian and the install-and-launch smoke tests included; two jobs failed on their environment.
AppImage: ubuntu-22.04's gcc bakes
_FORTIFY_SOURCE=2into its specs, the hardening block redefines it to 3, and-Werrorturns the redefinition fatal. The 24.04 CI runners never see it because their built-in already is 3. Fixed by undefining before defining, under the same not-Debug, not-sanitizer condition.Flatpak:
flatpak-buildershells out toeu-stripwhile finishing the libsodium module and the runner image does not carry elfutils. Added to the job's apt install.After merge: retag 0.1.0 on the fixed commit and the release reruns in full.