fix(release): SDL floor for the AppImage build, out-of-tree flatpak modules - #37
Merged
Merged
Conversation
…odules Jammy ships SDL 2.0.20 and the code uses SDL_GameControllerPath, which needs 2.24: the AppImage job now builds the pinned SDL 2.30.9 the Flatpak manifest already uses, after setup-qt so the prefix prepend survives that action's CMAKE_PREFIX_PATH overwrite. SDL2's CMakeLists also refuses an in-tree configure, which is flatpak-builder's cmake default; both cmake modules now set builddir.
emir-hasanbegovic
enabled auto-merge (squash)
August 23, 2026 14:22
emir-hasanbegovic
added a commit
that referenced
this pull request
Aug 23, 2026
…latpak module (#38) Attempt 3: the .deb and .rpm passed for the third straight time; the same two jobs advanced one layer each. **AppImage:** linuxdeploy's qt plugin deploys `libqxcb.so` and fails when a dependency does not resolve on the build host; jammy's runner image lacks `libxkbcommon-x11.so.0`. Installed the full xcb runtime block libqxcb links (xkbcommon-x11, cursor, icccm, image, keysyms, randr, render-util, shape, xinerama, xkb) instead of finding them one failed run at a time. **Flatpak:** #37's `builddir: true` on the dish module moved the post-install cwd out of the source tree, and the udev-rule copy is source-relative. Only SDL2's CMakeLists rejects in-tree configures; dish's does not, and in-tree is the configuration the manifest header's local build used. Reverted on dish, kept on sdl2, both manifests. Same follow-up: retag 0.1.0 on the merge commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt 2 of the 0.1.0 release got both failing jobs past their environment problems and into the next layer.
AppImage: jammy ships SDL 2.0.20;
SDLGamepadBridge.cppusesSDL_GameControllerPath/SDL_JoystickPath, which need 2.24. The job now builds the pinned SDL 2.30.9 (same version, checksum and gamepad-only feature set as the Flatpak manifest's sdl2 module) and linuxdeploy bundles it. The step runs after setup-qt because that action overwritesCMAKE_PREFIX_PATH; the SDL prefix prepends to it.Flatpak: SDL2's CMakeLists refuses an in-tree configure, and in-tree is flatpak-builder's default for cmake modules. Both cmake modules (
sdl2,dish) now setbuilddir: true, in the flathub variant too.Same follow-up as #36: retag 0.1.0 on the merge commit and the release reruns.