fix(ci): correct fastlane metadata path; park the unsupported bs listing - #157
Merged
Conversation
…the store icon for Supply
Contributor
Author
|
Added per-locale release notes for the next release as changelogs/10002.txt (assumes the next tag is 1.0.2; if it becomes 1.1.0, git mv them to 10100.txt). Content covers the only user-facing change since 1.0.1: Steam Controller over USB Direct (#154). All five files are 413 to 453 chars, and the lint passes with EXPECTED_VERSION_CODE=10002. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Commit 1: make the Play upload reach the API correctly.
fastlane supply --metadata_pathatplay/metadata/androidinstead ofplay/metadatainrelease.yml,play-listing.yml, and theplay/README.mdexample. Supply treats every child ofmetadata_pathas a Play locale, so the old path made it upload a single bogus locale namedandroid(Invalid requestfrom the Play API, first surfaced once the 1.0.1 run got past the disabled-API error).play/metadata/android/bs/toplay/metadata/unsupported/bs/. Google Play does not offer Bosnian (bs) as a store-listing language, so supply's upload for it is rejected outright. The translated listing content is parked rather than deleted; in-app Bosnian is unaffected.Commit 2: make sure a release can never ship half-empty again.
check_play_metadata.pyhard-fails whenEXPECTED_VERSION_CODEis set and any locale lackschangelogs/<code>.txt;release.ymlnow exposes the tag-derived versionCode as a job output and passes it to the lint, so a tag without release notes stops before the Play upload.play-listing.ymldoesn't set it, so listing-only syncs are unaffected.images/icon/to Supply'simages/icon.png, so the 512x512 store icon uploads automatically once it's committed; previously onlyfeatureGraphic/was flattened and a committed icon would have been silently ignored.changelogs/10000.txt) to10001.txtin all five locales: no 1.0.0 tag exists, so 1.0.1 is the initial public release and the "Initial release." copy is its release copy.Testing
validate_only=true, images included): fails on main (android - Invalid request, runs 31900131748 / 31900249999), Successfully validated the upload to Google Play on this branch for all 5 locales (runs 31900400508, 31900845136, the latter with the new flatten + lint in place). Validate-only builds the full edit server-side and discards it; no binary uploaded.EXPECTED_VERSION_CODE=10001= exit 0;EXPECTED_VERSION_CODE=10002= 5 missing-changelog errors, exit 1.images/icon/PNG: producesfeatureGraphic.pngfor all 5 locales plusicon.pngwhere present.