fix(ci): correct fastlane metadata path; park the unsupported bs listing (#157)

## What

Commit 1: make the Play upload reach the API correctly.

- Point `fastlane supply --metadata_path` at `play/metadata/android`
instead of `play/metadata` in `release.yml`, `play-listing.yml`, and the
`play/README.md` example. Supply treats every child of `metadata_path`
as a Play locale, so the old path made it upload a single bogus locale
named `android` (`Invalid request` from the Play API, first surfaced
once the 1.0.1 run got past the disabled-API error).
- Move `play/metadata/android/bs/` to `play/metadata/unsupported/bs/`.
Google Play does not offer Bosnian (`bs`) as a store-listing language,
so supply's upload for it is rejected outright. The translated listing
content is parked rather than deleted; in-app Bosnian is unaffected.

Commit 2: make sure a release can never ship half-empty again.

- `check_play_metadata.py` hard-fails when `EXPECTED_VERSION_CODE` is
set and any locale lacks `changelogs/<code>.txt`; `release.yml` now
exposes the tag-derived versionCode as a job output and passes it to the
lint, so a tag without release notes stops before the Play upload.
`play-listing.yml` doesn't set it, so listing-only syncs are unaffected.
- The flatten step (both workflows) now also flattens `images/icon/` to
Supply's `images/icon.png`, so the 512x512 store icon uploads
automatically once it's committed; previously only `featureGraphic/` was
flattened and a committed icon would have been silently ignored.
- Renamed the never-shipped 1.0.0 release notes (`changelogs/10000.txt`)
to `10001.txt` in all five locales: no 1.0.0 tag exists, so 1.0.1 is the
initial public release and the "Initial release." copy is its release
copy.
- README: documented the versionCode scheme, the
release-notes-before-tagging rule, and the icon/featureGraphic directory
convention.

## Testing

- Play Listing Sync (`validate_only=true`, images included): fails on
main (`android - Invalid request`, runs 31900131748 / 31900249999),
**Successfully validated the upload to Google Play** on this branch for
all 5 locales (runs 31900400508, 31900845136, the latter with the new
flatten + lint in place). Validate-only builds the full edit server-side
and discards it; no binary uploaded.
- Lint locally: no env = 5 icon warnings, exit 0;
`EXPECTED_VERSION_CODE=10001` = exit 0; `EXPECTED_VERSION_CODE=10002` =
5 missing-changelog errors, exit 1.
- Flatten loop locally with a simulated `images/icon/` PNG: produces
`featureGraphic.png` for all 5 locales plus `icon.png` where present.

Author: emir-hasanbegovic

.github/workflows/play-listing.yml

@@ -52,18 +52,21 @@ jobs:
       - name: Lint metadata before upload
         run: python3 scripts/check_play_metadata.py
 
-      - name: Flatten feature graphics for Supply
+      - name: Flatten feature graphics and icon for Supply
         shell: bash
-        # Supply expects images/featureGraphic.png; the repo keeps the
-        # active graphic as a named file inside images/featureGraphic/.
+        # Supply expects flat images/featureGraphic.png and images/icon.png;
+        # the repo keeps the active file as a named PNG inside
+        # images/featureGraphic/ and images/icon/.
         run: |
           set -euo pipefail
-          for dir in play/metadata/android/*/images/featureGraphic; do
+          for dir in play/metadata/android/*/images/featureGraphic play/metadata/android/*/images/icon; do
             [ -d "$dir" ] || continue
             active=$(find "$dir" -maxdepth 1 -name '*.png' | LC_ALL=C sort | head -1)
-            [ -n "$active" ] && cp "$active" "$(dirname "$dir")/featureGraphic.png"
+            if [ -n "$active" ]; then
+              cp "$active" "$(dirname "$dir")/$(basename "$dir").png"
+            fi
           done
-          find play/metadata -maxdepth 4 -name 'featureGraphic.png'
+          find play/metadata -maxdepth 4 \( -name 'featureGraphic.png' -o -name 'icon.png' \)
 
       - name: Install fastlane
         run: sudo gem install fastlane -N -v "~> 2.226"
@@ -82,7 +85,7 @@ jobs:
           fastlane supply \
             --json_key "${RUNNER_TEMP}/play-key.json" \
             --package_name com.tinkernorth.dish \
-            --metadata_path play/metadata \
+            --metadata_path play/metadata/android \
             --skip_upload_aab true \
             --skip_upload_apk true \
             --skip_upload_changelogs true \

.github/workflows/release.yml

@@ -126,6 +126,8 @@ jobs:
     needs: [gates, required-secrets]
     runs-on: ubuntu-latest
     timeout-minutes: 60
+    outputs:
+      version_code: ${{ steps.ver.outputs.code }}
     steps:
       - name: Checkout
         uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
@@ -321,19 +323,24 @@ jobs:
 
       - name: Lint metadata before upload
         if: ${{ steps.gate.outputs.enabled == 'true' && steps.artifacts.outputs.ready == 'true' }}
+        env:
+          EXPECTED_VERSION_CODE: ${{ needs.release.outputs.version_code }}
         run: python3 scripts/check_play_metadata.py
 
-      - name: Flatten feature graphics for Supply
+      - name: Flatten feature graphics and icon for Supply
         if: ${{ steps.gate.outputs.enabled == 'true' && steps.artifacts.outputs.ready == 'true' }}
         shell: bash
-        # Supply expects images/featureGraphic.png; the repo keeps the
-        # active graphic as a named file inside images/featureGraphic/.
+        # Supply expects flat images/featureGraphic.png and images/icon.png;
+        # the repo keeps the active file as a named PNG inside
+        # images/featureGraphic/ and images/icon/.
         run: |
           set -euo pipefail
-          for dir in play/metadata/android/*/images/featureGraphic; do
+          for dir in play/metadata/android/*/images/featureGraphic play/metadata/android/*/images/icon; do
             [ -d "$dir" ] || continue
             active=$(find "$dir" -maxdepth 1 -name '*.png' | LC_ALL=C sort | head -1)
-            [ -n "$active" ] && cp "$active" "$(dirname "$dir")/featureGraphic.png"
+            if [ -n "$active" ]; then
+              cp "$active" "$(dirname "$dir")/$(basename "$dir").png"
+            fi
           done
 
       - name: Install fastlane
@@ -359,7 +366,7 @@ jobs:
             --release_status "${PLAY_RELEASE_STATUS}" \
             --aab "${AAB}" \
             "${mapping_args[@]}" \
-            --metadata_path play/metadata \
+            --metadata_path play/metadata/android \
             --skip_upload_metadata false \
             --skip_upload_images false \
             --skip_upload_screenshots false \

play/README.md

@@ -0,0 +1,6 @@
+Steam-Controller-Unterstützung.
+
+• Läuft im Direktmodus über USB, per Kabel oder Dongle (Opt-in).
+• Sticks, Trigger, Tasten, Motion und das rechte Trackpad als rechter Stick.
+• Solange Dish ihn nutzt, wirkt er nicht mehr als Maus und Tastatur am Handy und wird danach unverändert zurückgegeben.
+• Fällt ein Pad vom Dongle, bleibt keine Eingabe mehr hängen; beim Wiederverbinden richtet es sich automatisch neu ein.

…adata/android/de-DE/changelogs/10000.txt …adata/android/de-DE/changelogs/10001.txtplay/metadata/android/de-DE/changelogs/10000.txt renamed to play/metadata/android/de-DE/changelogs/10001.txt play/metadata/android/de-DE/changelogs/10000.txt renamed to play/metadata/android/de-DE/changelogs/10001.txt

@@ -0,0 +1,6 @@
+Steam Controller support.
+
+• Works in Direct mode over USB, wired or through the dongle (opt-in).
+• Sticks, triggers, buttons, motion, and the right trackpad as a right stick.
+• While Dish uses it, it stops doubling as a mouse and keyboard for the phone, and is handed back exactly as it was.
+• A pad that drops off the dongle no longer holds its last input, and it sets up again automatically when it reconnects.

play/metadata/android/de-DE/changelogs/10002.txt

@@ -0,0 +1,6 @@
+Compatibilidad con el Steam Controller.
+
+• Funciona en Modo directo por USB, con cable o mediante el dongle (opcional).
+• Sticks, gatillos, botones, motion y el trackpad derecho como stick derecho.
+• Mientras Dish lo usa, deja de actuar como ratón y teclado del teléfono, y se devuelve tal como estaba.
+• Si un mando se desconecta del dongle ya no deja su última entrada retenida, y al reconectarse se configura de nuevo automáticamente.