Repository navigation
S8b Rust port: sessions II — grants, last_reply, bind_work tests + parity grant steps (WI-1074) - #1083
Merged
Conversation
Adds engine-down parity steps for the session grant, history, bind_work, last_reply, search_output, blocked report, changes, wait_any, commit_for, economics and digest operations, and for agent_activity search and summary. The golden is not re-recorded here: the 21c95f6 golden needs one serialized re-record before `parity.py check` passes on these steps. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
…I-1074) WIP checkpoint. Adds the missing grant invariant tests against a stand-in engine (refusal stays pending, overseer-only asks, requester is the principal, self-nomination refused, rollback and race on approval, the one named credential, TTL expiry, revoke, audit by name, inbox entry), a cfg(test) record seam in grants.rs, list-level last-reply excerpt and running-model tests, and the session side of bind_work (rebind/unbind, declared branch, child and self binds, refusals, engine label refused, unlinked binding). Parity step item (real grant for decide/revoke) is not done yet. Golden not re-recorded. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
…-1074)
The grant decide and revoke steps used a made-up id, so they failed as
not_found before the person gate ran. parity.py now serves a loopback
stand-in engine for steps marked "engine": true, and a param can name an
earlier step's answer with {seen:<op>#<dotted.key>}. The grant request
creates a real grant for a live worker, then the person decides and the
person revokes it. The CLI harness runs as the local person, so the
agent side of WI-983 is still covered only by the Rust unit tests. The
21c95f6 golden is not re-recorded.
Also: health.rs no longer sets VOGT_TEST_IDS process-wide, which made every
later context in the test process use sequential ids and collide when a
second context opened the same store.
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Signed-off-by: sprooty <sprooty@sprooty.com>
…session steps (WI-1074)
mcp.json is left as recorded on rust-core: the MCP runner does not resolve
the ${seen} references the new grant steps use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: sprooty <sprooty@sprooty.com>
thedancingdeveloper
force-pushed
the
wi-1074-s8b-sessions-ii-core
branch
from
October 17, 2026 09:10
49971bb to
1286273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WI-1074 (S8b). Reviewed at 49971bb: no blockers.
grants.rsagainst a stand-in engine (refusal stays pending, overseer-only asks, agent cannot self-nominate, rollback/race on approval, TTL expiry, revoke, audit, inbox);cfg(test)record seam onlysession_reads.rs; 7 bind_work session-side tests insession_work.rsparity.py: loopback stand-in engine for"engine": truesteps and{seen:<op>#<key>}references; grant_request → decide → revoke now runs on a real grant (grt_0001)health.rstest no longer leaksVOGT_TEST_IDS=sequentialprocess-wideGolden 21c95f6 is deliberately not re-recorded; it needs one serialized re-record before
parity.py checkcovers the new steps.Gates (reviewer, at 49971bb): cargo fmt --check, clippy -D warnings clean; cargo test -p vogt-core 903+4+3 passed; parity record --impl rust --only session. 29 steps all match expected exits.
🤖 Generated with Claude Code