Repository navigation
S9 Rust port: MCP parity fixed scratch root (import consolidation landed via #1084) (WI-1075) - #1086
Merged
Merged
Conversation
The audit payload_digest covers the absolute root_path a project is registered at. The MCP run used a random temp directory, so every digest over a registered project changed from run to run, in both cores. The output already shows the root as <root>; only the digest saw the path. The MCP run now uses a fixed, cleared-before-and-after scratch path. Runs are sequential, so the path is safe to reuse. With it, Python and Rust produce identical MCP digests (checked line by line, 6 digests). The 21c95f6 MCP golden is not re-recorded here: its digests were taken at a random path and will differ until oversight re-records it. Signed-off-by: sprooty <sprooty@sprooty.com> Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
#1085 added the test without a ledger row, so every_python_test_has_one_disposition failed on rust-core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: sprooty <sprooty@sprooty.com>
thedancingdeveloper
force-pushed
the
wi-1075-s9-rust
branch
from
October 17, 2026 11:06
1cc2d05 to
e0d4300
Compare
thedancingdeveloper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S9's
project.importconsolidation work already landed via #1084 (WI-1725), which consolidates by default as Python does (consolidate: bool = Field(default=True)). This PR's two import commits (ce3c9d4, 8b01475) conflicted with #1084 and would have changed that default, so they are dropped.What remains:
scripts/parity.pyonly.test_engine_image_core.py: WI-1078 (I3): ship the Rust vogt-core in the stack image #1085 (WI-1078) added that test without a ledger row, soevery_python_test_has_one_dispositionwas failing on rust-core's tip. Markedretired: it holds static checks on the engine Dockerfile and entrypoint, not the core crate.Golden 21c95f6 re-recorded from Python. The CLI and HTTP goldens are unchanged.
Known gap, not fixed here:
parity.py record --transport mcpstill crashes withKeyError: 'session.grant_request'. The MCP runner never fillsseen; this has been so since #1083 (noted on WI-1074). Because the MCP run stops there, MCPpayload_digestparity can't be checked yet, andmcp.jsonis stale againstscript.json. CI does not record or check MCP.Gates: the rust-core.yml parity sequence,
gen_registry --check,gen_validator_corpus --check,cargo fmt --check,cargo clippy --workspace --all-targets -D warnings,cargo test -p vogt-core(930 passed).🤖 Generated with Claude Code