Skip to content

[BUGFIX] Do not force absolute uri for relative links #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszuznanski merged 1 commit into from
May 21, 2026
Merged

[BUGFIX] Do not force absolute uri for relative links #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Classes/Utility/UrlUtility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ public function getFrontendUrlWithSite($url, SiteInterface $site, string $return
$this->handleLanguageConfiguration($siteLanguage, $this);
}

if (!$this->headlessMode->isEnabled() || $this->alreadyFrontendLink($url)) {
$targetUri = new Uri($this->sanitizeBaseUrl($url));

if (!$this->headlessMode->isEnabled() || $this->alreadyFrontendLink($url) || $targetUri->getHost() === '') {
return $url;
}

Expand All @@ -108,7 +110,7 @@ public function getFrontendUrlWithSite($url, SiteInterface $site, string $return
$frontBase = $frontendBase->getHost();
$frontExtraPath = $frontendBase->getPath();
$frontPort = $frontendBase->getPort();
$targetUri = new Uri($this->sanitizeBaseUrl($url));

$targetUri = $targetUri->withHost($frontBase);
if ($targetUri->getScheme() === '') {
$targetUri = $targetUri->withScheme($frontendBase->getScheme());
Expand Down
7 changes: 7 additions & 0 deletions Tests/Unit/Utility/UrlUtilityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ public function testOptimizedUrlsForFrontendApp(): void
],
],
]);
$site->getLanguages()->willReturn([]);

$resolver = $this->prophesize(Resolver::class);
$resolver->evaluate(Argument::containingString('Development'))->willReturn(true);
Expand Down Expand Up @@ -271,6 +272,12 @@ public function testOptimizedUrlsForFrontendApp(): void
$urlUtility->prepareRelativeUrlIfPossible('https://test-second-frontend.tld/test-page')
);

// do not touch already relative links
self::assertSame(
'/test-page',
$urlUtility->getFrontendUrlWithSite('/test-page', $site->reveal())
);

// test reversed = "Testing" condition
$resolver = $this->prophesize(Resolver::class);
$resolver->evaluate(Argument::containingString('Development'))->willReturn(false);
Expand Down
Loading