[BUGFIX] Do not force absolute uri for relative links - #890
Merged
Conversation
Coverage Report for CI Build 25857501429Warning No base build found for commit Coverage: 72.849%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
|
seems like in v14 this is ignored, again |
Collaborator
Author
|
Not again, but this PR contains fix #893 for this issue for 5.x branch, this is for 4.x releases |
|
Thx! |
kitzberger
added a commit
to GFEMediaGmbH/headless
that referenced
this pull request
Jul 30, 2026
When getFrontendUrlWithSite() receives a relative URL (e.g.
/powermail/optin/{hash}/{mail}), the early-return guard
->getHost() === '' caused the URL to be returned
unchanged without prepending the configured frontendBase.
The intent of that check (introduced in TYPO3-Headless#890) was to prevent
external URLs from being rewritten, but it was too broad: it
blocked ALL relative URLs since they have no host component.
This fix removes the empty-host check and adds an empty-host
guard to isExternalUrl() so that relative URLs are correctly
identified as non-external and get rewritten to absolute
frontend URLs.
Resolves: TYPO3-Headless#903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #889