CI: run the release artifact actions on Node 24 - #72
Merged
Conversation
actions/upload-artifact@v4 and actions/download-artifact@v4 target Node.js 20, so every release run is annotated with the Node 20 deprecation warning. The rest of the workflows moved to Node 24 action majors in #35 (checkout@v5, setup-python@v6); this brings the release workflow in line. The two actions' majors are offset by one, so they cannot both take the same number. v5 (upload) and v6 (download) only added preliminary Node 24 support and still default to Node 20, which would leave the warning in place; upload v6 and download v7 are the first to set 'runs.using: node24'. This takes the latest matched pair -- upload v7 with download v8 -- since upload v7's direct uploads are what download v8's direct downloads consume. Behaviour notes: * download-artifact v8 defaults 'digest-mismatch' to error rather than warn, so a corrupted download now fails the run instead of publishing silently. * Both require Actions Runner >= 2.327.1; the workflow runs on GitHub-hosted ubuntu-latest. * The multi-path upload (dist/ plus notes.md) is unaffected: the paths still resolve through their least common ancestor to the workspace root, so both downstream jobs see 'dist/*' beside 'notes.md'. v7's single-file restriction applies only with 'archive: false'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the release workflow's artifact actions off Node.js 20, which the other workflows left behind
in #35.
release.ymlwas the last one still emitting the Node 20 deprecation annotation.actions/upload-artifact@v4->@v7actions/download-artifact@v4->@v8(both thegithub-releaseandpypijobs)The two actions' majors are offset by one, so they take different numbers: v5 (upload) and v6
(download) still default to Node 20, and v7/v8 are the latest matched pair.
One behaviour change:
download-artifactv8 defaultsdigest-mismatchtoerror, so a downloadwhose hash does not match now fails the run instead of publishing.
The multi-path upload (
dist/plusnotes.md) and the resulting layout are unchanged. End-to-endvalidation happens on the next
v*tag push;ci.ymldoes not exerciserelease.yml.