Skip to content

Wire up the --fullscreen flag #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcmendez wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −6
Open

Wire up the --fullscreen flag #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ int main(int argc, char *argv[])
engine.rootContext()->setContextProperty("defaultCmdArgs", commandArgs);

engine.rootContext()->setContextProperty("workdir", getNamedArgument(args, "--workdir", QDir::currentPath()));
engine.rootContext()->setContextProperty("startFullscreen", args.contains("--fullscreen"));
engine.rootContext()->setContextProperty("fileIO", &fileIO);

// Manage import paths for Linux and OSX.
Expand Down
8 changes: 2 additions & 6 deletions app/qml/TerminalWindow.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,12 @@ ApplicationWindow {
height: 768

// Show the window once it is ready.
Component.onCompleted: {
visible = true
}
Component.onCompleted: visibility = (fullscreen ? Window.FullScreen : Window.Windowed)

minimumWidth: 320
minimumHeight: 240

visible: false

property bool fullscreen: false
property bool fullscreen: startFullscreen
onFullscreenChanged: visibility = (fullscreen ? Window.FullScreen : Window.Windowed)

menuBar: WindowMenu { }
Expand Down