Wire up the --fullscreen flag - #966
Open
jcmendez wants to merge 1 commit into
Open
Conversation
The flag was documented in --help but never actually implemented: nothing set a context property for it and no QML read it, so passing --fullscreen was silently a no-op. TerminalWindow now picks up its initial fullscreen state from this. Also drops the separate visible/Component.onCompleted dance in favor of a single visibility assignment, since setting both visible and visibility explicitly (which happened whenever fullscreen started true) triggers a QtQuick "Conflicting properties" warning and the fullscreen request was silently lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fullscreenhas been documented in--helpfor a while but was never actually implemented: nothing set a related context property, and no QML read one, so passing--fullscreenwas silently a no-op (the terminal always opened as a normal window).app/main.cppnow exposes astartFullscreenroot context property based onargs.contains("--fullscreen").app/qml/TerminalWindow.qml'sfullscreenproperty now defaults to that instead of a hardcodedfalse.visible: false/Component.onCompleted { visible = true }pattern into a singlevisibilityassignment. Keeping bothvisibleandvisibilityexplicitly set (which now happens wheneverfullscreenstartstrue) triggers QtQuick'sConflicting properties 'visible' and 'visibility'warning, and the fullscreen request was silently dropped as a result.Test plan
--fullscreen: window now opens fullscreen, no more "Conflicting properties" warning in the log