feat: #809, when a member gets registered to a shift, unfreeze them r… - #812
Open
Theophile-Madet wants to merge 2 commits into
Open
feat: #809, when a member gets registered to a shift, unfreeze them r…#812Theophile-Madet wants to merge 2 commits into
Theophile-Madet wants to merge 2 commits into
Conversation
…ight away if relevant.
Contributor
|
So just registering to shift should unfreeze users? If I want to abuse that, I could just register to shifts but never attend right? |
Collaborator
Author
That's true:, it's possible to abuse the system by registering to a shift in ~7 weeks and deregistering 2 weeks before the shift, then repeat. We thought it's unlikely to happen and the advantages for members trying to get active again are more important than the potential abuse. Also, the abuse is possible before this PR, this just makes the unfreezing instant instead of happening in the following night. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ight away if relevant.