fix(ci): run npm publish job on Node 24#59
Merged
Conversation
npm@latest is now npm@12, which dropped Node 20 (requires Node >=22.22 || >=24.15), so the "Upgrade npm for OIDC support" step (npm install -g npm@latest) fails on the Node 20 runner. Bump the publish job to Node 24. Broke the v0.14.0 release publish; 0.14.0 never reached npm. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions publish workflow's Node.js setup step is updated from Node.js 20 to Node.js 24, with accompanying comment changes explaining that npm@latest dropped Node 20 support and that OIDC trusted publishing requires the newer Node version. ChangesPublish Workflow Update
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.14.0 release publish failed: the Upgrade npm for OIDC support step runs
npm install -g npm@latest, which now resolves to npm@12 — and npm@12 dropped Node 20 (requires Node >=22.22 || >=24.15). The publish job runs on Node 20.20.2, so the step errorsEBADENGINEbefore publishing. 0.14.0 never reached npm.(0.13.0 published fine yesterday because npm@latest was still Node-20-compatible then.)
Fix
Bump the publish job's Node to 24. After merge, the v0.14.0 release will be re-cut so the tag includes this workflow.
🤖 Generated with Claude Code
Summary by CodeRabbit