Skip to content

fix(ci): run npm publish job on Node 24#59

Merged
lukemacauley merged 1 commit into
mainfrom
fix/publish-node-version
Jul 9, 2026
Merged

fix(ci): run npm publish job on Node 24#59
lukemacauley merged 1 commit into
mainfrom
fix/publish-node-version

Conversation

@lukemacauley

@lukemacauley lukemacauley commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Problem

The v0.14.0 release publish failed: the Upgrade npm for OIDC support step runs npm install -g npm@latest, which now resolves to npm@12 — and npm@12 dropped Node 20 (requires Node >=22.22 || >=24.15). The publish job runs on Node 20.20.2, so the step errors EBADENGINE before publishing. 0.14.0 never reached npm.

(0.13.0 published fine yesterday because npm@latest was still Node-20-compatible then.)

Fix

Bump the publish job's Node to 24. After merge, the v0.14.0 release will be re-cut so the tag includes this workflow.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the release/publish workflow to use a newer Node.js version.
    • Improved the workflow notes to reflect the current publishing requirements.

npm@latest is now npm@12, which dropped Node 20 (requires Node >=22.22 || >=24.15),
so the "Upgrade npm for OIDC support" step (npm install -g npm@latest) fails on the
Node 20 runner. Bump the publish job to Node 24. Broke the v0.14.0 release publish;
0.14.0 never reached npm.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7bf17f7-79b9-44f8-b3ac-cdca0fe1d4e5

📥 Commits

Reviewing files that changed from the base of the PR and between 23da4a8 and 4a143b1.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml

📝 Walkthrough

Walkthrough

The GitHub Actions publish workflow's Node.js setup step is updated from Node.js 20 to Node.js 24, with accompanying comment changes explaining that npm@latest dropped Node 20 support and that OIDC trusted publishing requires the newer Node version.

Changes

Publish Workflow Update

Layer / File(s) Summary
Node.js version bump
.github/workflows/publish.yml
The actions/setup-node@v4 step is changed from Node 20 to Node 24, with comments updated to explain the npm@latest and OIDC trusted publishing requirements.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/publish-node-version

Comment @coderabbitai help to get the list of available commands.

@lukemacauley
lukemacauley merged commit 732201e into main Jul 9, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant