fix(ci): pin npm@11 for publish + add workflow_dispatch#61
Merged
Conversation
npm@12 (the current @latest) ships a broken provenance path that fails with "Cannot find module 'sigstore'", breaking npm publish. Pin npm@11, which published every release through 0.13.0. Add workflow_dispatch so a version whose release already fired (v0.14.1) can be published from main without cutting a new tag (immutable releases burn a tag on the failed release). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions publish workflow adds a workflow_dispatch trigger for manual publishing and pins the npm upgrade step to npm@11 instead of npm@latest, updating accompanying comments about Node/npm version compatibility. ChangesPublish Workflow Update
Estimated code review effort: 1 (Trivial) | ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #59. With Node 20→24 fixed, the publish then failed at the actual publish step:
npm install -g npm@latestnow installs npm@12, whose provenance code fails withCannot find module 'sigstore'(run).npm@11— the version that published every release through 0.13.0 (npm@12 provenance is broken).workflow_dispatch— v0.14.1's release already fired and failed, and immutable releases burn that tag, so this lets us publish the 0.14.1 already onmainby manually running the workflow — no new version/tag needed.After merge: run the Publish workflow on
main→ 0.14.1 to npm.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes