Skip to content

Feat: spawn egg - #412

Merged
JunkyDeveloper merged 40 commits into
Steel-Foundation:masterfrom
chocodev11:feat/spawn-egg
Sep 8, 2026
Merged

JunkyDeveloper merged 40 commits into
Steel-Foundation:masterfrom
chocodev11:feat/spawn-egg

Conversation

@chocodev11

@chocodev11 chocodev11 commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • Item implementation
  • Command implementation
  • Refactor / code cleanup

Description

How this was tested

Screenshots / logs

Checklist

  • Code builds w/o errors or warnings
  • Self-reviewed the diff
  • Docs updated (if applicable)
  • No leftover debug code / comments

Additional notes

@chocodev11
chocodev11 marked this pull request as draft August 21, 2026 06:46
@chocodev11
chocodev11 marked this pull request as ready for review August 22, 2026 09:17
Copilot AI lite review requested due to automatic review settings August 22, 2026 09:17
Copilot stopped reviewing on behalf of chocodev11 due to an error August 22, 2026 09:38

@Laptop59 Laptop59 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my review for now:

Comment thread steel-core/src/behavior/items/spawn_egg.rs Outdated
Comment thread steel-core/src/behavior/items/spawn_egg.rs
Comment thread steel-core/src/behavior/items/spawn_egg.rs Outdated
@github-actions

Copy link
Copy Markdown

This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes.

@github-actions

Copy link
Copy Markdown

Conflicts have been resolved! 🎉

Comment thread steel-core/src/behavior/items/spawn_egg.rs Outdated
@JunkyDeveloper

Copy link
Copy Markdown
Contributor

fix lint!

Comment thread steel-core/src/entity/spawn.rs
@github-actions github-actions Bot added Command Item Request/implementation/Bug of an tiem labels Aug 24, 2026
JunkyDeveloper
JunkyDeveloper previously approved these changes Sep 8, 2026
@JunkyDeveloper

Copy link
Copy Markdown
Contributor

What did I do:

  • switched from shrink to consume
  • fix merge conflicts
  • fmt
  • Extended the todo for the spawner to also check the condition depends when it will be implemented
  • created Refactor ageable mob #630 for the ageable bug in this PR, because it is a bigger refactor

@kdcokenny kdcokenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also my earlier review #412 (comment) seems unaddressed?

Comment thread steel-core/src/entity/entity/mod.rs
@chocodev11

Copy link
Copy Markdown
Contributor Author

thanks for your review, im in school year now so i cant do much

@kdcokenny

Copy link
Copy Markdown
Contributor

thanks for your review, im in school year now so i cant do much

Would it be helpful if i finish the impl for you? I can just open up a pr into this PR or something

@JunkyDeveloper

Copy link
Copy Markdown
Contributor

exractor PR for the only_op_can_set: Steel-Foundation/SteelExtractor#28

JunkyDeveloper
JunkyDeveloper previously approved these changes Sep 8, 2026

@coco875 coco875 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing I will likely make a commit

Comment thread steel-core/src/entity/spawn.rs Outdated
@JunkyDeveloper
JunkyDeveloper dismissed CuzImClicks’s stale review September 8, 2026 22:16

all change requests are done

@JunkyDeveloper
JunkyDeveloper merged commit 589395c into Steel-Foundation:master Sep 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants