Skip to content

Rework nbt entity data load #644

Open

Description

@JunkyDeveloper

at #412 @kdcokenny wrote this comment

this skips the living entity fields from ENTITY_DATA. the mob loaders don't load Health, attributes, or active_effects, but vanilla's LivingEntity.readAdditionalSaveData does.

i tested the merged data with Age:-24000 and Health:1.0f. age applied, but the pig stayed at 10 health instead of 1. this isn't the numeric coercion issue in #559, the health tag is already a float.

But instead of doing a hot fix, we should maybe rework the system and look into doing our own, which can handle things better and easier to implement future entities

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions